[Remote State] Upload incremental cluster state on master re-election #15145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Cluster Manager
ClusterManager:RemoteState
v2.16.0
|
❌ Gradle check result for 9710a15: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
server/src/main/java/org/opensearch/cluster/coordination/CoordinationState.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/opensearch/cluster/coordination/CoordinationState.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/opensearch/cluster/coordination/PublicationTransportHandler.java
Show resolved
Hide resolved
shiv0408
added
skip-changelog
v2.17.0
and removed
v2.16.0
shiv0408
requested review from
anasalkouz,
andrross,
ashking94,
Bukhtawar,
CEHENKLE,
dblock,
dbwiddis,
gbbafna,
kotwanikunal,
mch2,
msfroh,
nknize,
owaiskazi19,
reta,
Rishikesh1159,
sachinpkale,
saratvemulapalli,
shwetathareja,
sohami and
VachaShah
as code owners
|
The backport to To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.x
# Create a new branch
git switch --create backport/backport-15145-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 cbdcbb7da3d87fdccfca164ac8f6914a55dc19cb
# Push it to GitHub
git push --set-upstream origin backport/backport-15145-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.xThen, create a pull request where the |
|
The backport to To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.17 2.17
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.17
# Create a new branch
git switch --create backport/backport-15145-to-2.17
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 cbdcbb7da3d87fdccfca164ac8f6914a55dc19cb
# Push it to GitHub
git push --set-upstream origin backport/backport-15145-to-2.17
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.17Then, create a pull request where the |
shiv0408
added a commit
to shiv0408/OpenSearch
that referenced
this pull request
Sep 6, 2024
…opensearch-project#15145) * Upload incremental cluster state on master re-election Signed-off-by: Shivansh Arora <hishiv@amazon.com> (cherry picked from commit cbdcbb7)
shwetathareja
pushed a commit
that referenced
this pull request
Sep 6, 2024
This was referenced Sep 6, 2024
shiv0408
added a commit
to shiv0408/OpenSearch
that referenced
this pull request
Sep 9, 2024
…opensearch-project#15145) * Upload incremental cluster state on master re-election Signed-off-by: Shivansh Arora <hishiv@amazon.com> (cherry picked from commit cbdcbb7)
shwetathareja
pushed a commit
that referenced
this pull request
Sep 9, 2024
akolarkunnu
pushed a commit
to akolarkunnu/OpenSearch
that referenced
this pull request
Sep 10, 2024
…opensearch-project#15145) * Upload incremental cluster state on master re-election Signed-off-by: Shivansh Arora <hishiv@amazon.com>
This was referenced Sep 11, 2024
dk2k
pushed a commit
to dk2k/OpenSearch
that referenced
this pull request
Oct 16, 2024
…opensearch-project#15145) * Upload incremental cluster state on master re-election Signed-off-by: Shivansh Arora <hishiv@amazon.com>
dk2k
pushed a commit
to dk2k/OpenSearch
that referenced
this pull request
Oct 17, 2024
…opensearch-project#15145) * Upload incremental cluster state on master re-election Signed-off-by: Shivansh Arora <hishiv@amazon.com>
dk2k
pushed a commit
to dk2k/OpenSearch
that referenced
this pull request
Oct 21, 2024
…opensearch-project#15145) * Upload incremental cluster state on master re-election Signed-off-by: Shivansh Arora <hishiv@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently we upload full cluster state when master re-election happens. This can lead to un-neccessary upload of cluster state attributes even if no change is there in the cluster state attributes. If the cluster has lots of indices or other state metadata. Uploading state every time a node is trying to get elected as cluster manager, the overhead of uploading the cluster state can be big and can problems like S3 throttling or election loop.
Also, when we receive a publication request on a node where the Remote Publication is marked as enabled, but the publication is from Transport channel, we reset the last accepted state and manifest in our RemotePersistedState object to avoid any stale value being persisted on the nodes. Now if these nodes try to become cluster manager, they will be uploading the full state, which rather than uploading a diff from stale state.
Related Issues
Resolves #10682
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.